SOLAPI Node.js SDK 6.0.0-beta#115
Merged
Palbahngmiyine merged 1 commit intosolapi:betafrom Apr 8, 2026
Merged
Conversation
BREAKING CHANGE: 전체 API를 Effect 라이브러리 기반으로 마이그레이션 - 모든 타입과 스키마를 외부로 export - Data.TaggedError 기반 에러 처리 통일 - Effect.gen + Effect.tryPromise 비동기 처리 - Effect Schema 기반 입력 검증 - runSafePromise()/runSafeSync() Promise 변환 유틸 도입 - authenticator를 Effect.try로 래핑 - finalize Defect 방지 및 Kakao 입력 검증 - 테스트 환경변수 SOLAPI_ 접두사 통일 - effectErrorHandler, schemaUtils, getGroupsRequest, getMessagesRequest 테스트 추가 Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
![gemini-code-assist[bot]](https://avatars.githubusercontent.com/in/956858?s=60&v=4){kind=small}
There was a problem hiding this comment.
Code Review
This pull request represents a major update to version 6.0.0, refactoring the SDK to leverage the Effect library for robust functional programming and runtime schema validation. The changes include a comprehensive migration of models to Effect Schema, the introduction of standardized error handling patterns, and the refactoring of core services and utilities to support Effect-based asynchronous flows. Feedback was provided regarding a typo in the documentation for a utility filename.
| | `authenticator.ts` | HMAC-SHA256 auth header | | ||
| | `stringifyQuery.ts` | URL query string builder (array handling) | | ||
| | `fileToBase64.ts` | File/URL → Base64 | | ||
| | `stringDateTrasnfer.ts` | Date parsing with `InvalidDateError` | |
There was a problem hiding this comment.
파일명에 오타가 있습니다. stringDateTrasnfer.ts는 stringDateTransfer.ts가 되어야 합니다.
Suggested change
| | `stringDateTrasnfer.ts` | Date parsing with `InvalidDateError` | | |
| | `stringDateTransfer.ts` | Date parsing with `InvalidDateError` | |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
기능 변경사항
Data.TaggedError기반 에러 처리 통일Effect.gen+Effect.tryPromise비동기 처리runSafePromise()/runSafeSync()Promise 변환 유틸을 도입했습니다.Effect.try로 래핑하고unwrapCause를 추출했습니다.프로젝트 내부 변경사항
Test plan
🤖 Generated with Claude Code